ivatar issueshttps://git.linux-kernel.at/oliver/ivatar/-/issues2021-09-06T11:51:16Zhttps://git.linux-kernel.at/oliver/ivatar/-/issues/39For email confirmation, you need to be logged when clicking on a link in the ...2021-09-06T11:51:16ZGhost UserFor email confirmation, you need to be logged when clicking on a link in the emailThis is rather a question. I noticed I need to be logged in when clicking a confirm link in the received confirmation email. If I am not logged in into libravatar at that moment, the email want get verified/confirmed. I don't think being...This is rather a question. I noticed I need to be logged in when clicking a confirm link in the received confirmation email. If I am not logged in into libravatar at that moment, the email want get verified/confirmed. I don't think being logged in is usually required when confirming an email address.Oliver Falkoliver@linux-kernel.atOliver Falkoliver@linux-kernel.athttps://git.linux-kernel.at/oliver/ivatar/-/issues/38disable exception stacktraces getting into browser on production2021-09-06T11:51:05ZGhost Userdisable exception stacktraces getting into browser on productionHello, on production (https://libravatar.fedorainfracloud.org), right now, when an exception is raised, it gets displayed in browser. We should very likely disable it for production. I am now not sure which Django settings influences it ...Hello, on production (https://libravatar.fedorainfracloud.org), right now, when an exception is raised, it gets displayed in browser. We should very likely disable it for production. I am now not sure which Django settings influences it but we definitely want a different settings for production and different for developement.Oliver Falkoliver@linux-kernel.atOliver Falkoliver@linux-kernel.athttps://git.linux-kernel.at/oliver/ivatar/-/issues/37libravatar's sends email with FROM: accounts@mg.linux-kernel.at2021-09-06T11:51:01ZGhost Userlibravatar's sends email with FROM: accounts@mg.linux-kernel.atI think it might be related to the following settings in config.py (although it comes before `DEFAULT_FROM_EMAIL = os.environ.get('DEFAULT_FROM_EMAIL', 'ivatar@mg.linux-kernel.at')` strangely).
```
SERVER_EMAIL = 'accounts@mg.linux-kern...I think it might be related to the following settings in config.py (although it comes before `DEFAULT_FROM_EMAIL = os.environ.get('DEFAULT_FROM_EMAIL', 'ivatar@mg.linux-kernel.at')` strangely).
```
SERVER_EMAIL = 'accounts@mg.linux-kernel.at'
DEFAULT_FROM_EMAIL = SERVER_EMAIL
```
...Actually looking into models.py `SERVER_EMAIL` varaiable is used as `send_email`'s parameter.
We probably want to:
```
SERVER_EMAIL = os.environ.get('SERVER_EMAIL', 'accounts@mg.linux-kernel.at')
```
Or maybe we can just keep `DEFAULT_FROM_EMAIL`?https://git.linux-kernel.at/oliver/ivatar/-/issues/36on libravatar-stg there is still the "old" navbar on homepage when logged in2021-09-06T11:50:55ZGhost Useron libravatar-stg there is still the "old" navbar on homepage when logged inHello, when I am logged in on libravatar-stg (devel branch), I get the "old" navbar displayed. I think this has been updated in a recent PR.
![Screenshot_from_2019-02-05_20-44-47](/uploads/aedbdc378fcde45457c79babd6e30666/Screenshot_fro...Hello, when I am logged in on libravatar-stg (devel branch), I get the "old" navbar displayed. I think this has been updated in a recent PR.
![Screenshot_from_2019-02-05_20-44-47](/uploads/aedbdc378fcde45457c79babd6e30666/Screenshot_from_2019-02-05_20-44-47.png)https://git.linux-kernel.at/oliver/ivatar/-/issues/35check tool doesn't work properly2021-09-06T11:50:48ZGhost Usercheck tool doesn't work properlyHello!
on https://libravatar-stg.fedorainfracloud.org/, I've deleted all the users to start from a fresh environment. I then created user clime, added an openID https://clime.id.fedoraproject.org and uploaded a photo for this openID.
I...Hello!
on https://libravatar-stg.fedorainfracloud.org/, I've deleted all the users to start from a fresh environment. I then created user clime, added an openID https://clime.id.fedoraproject.org and uploaded a photo for this openID.
I then tried to check the openID and the photo for it by the check tool but check tool doesn't display the photo for some reason, when I put https://clime.id.fedoraproject.org into OpenId field, just a default avatar for sha512 is displayed.Oliver Falkoliver@linux-kernel.atOliver Falkoliver@linux-kernel.athttps://git.linux-kernel.at/oliver/ivatar/-/issues/34ivatar vs. libravatar name on home page2021-09-06T11:50:41ZGhost Userivatar vs. libravatar name on home pageHello, I think we want the home page on https://libravatar.fedorainfracloud.org/ to say:
"libravatar"
"freeing the web one face at a time"
instead of:
"ivatar"
"freeing the web one face at a time"
I understand ivatar is the name of t...Hello, I think we want the home page on https://libravatar.fedorainfracloud.org/ to say:
"libravatar"
"freeing the web one face at a time"
instead of:
"ivatar"
"freeing the web one face at a time"
I understand ivatar is the name of the software but i don't think users need to know the software is actually named differently.
Similarly, we should modify:
<title>iVatar :: federated avatar hosting service</title>
Maybe this can be done by adding a configuration variable SERVICE_NAME and using that in the template?https://git.linux-kernel.at/oliver/ivatar/-/issues/33what is ALLOWED_EXTERNAL_OPENID_REDIRECT_DOMAINS good for2021-09-06T11:50:25ZGhost Userwhat is ALLOWED_EXTERNAL_OPENID_REDIRECT_DOMAINS good forHello,
there is configuration option ALLOWED_EXTERNAL_OPENID_REDIRECT_DOMAINS. Is it good for something? OPENID login is working on libravatar-stg even though the domain name is currently not being present in the above-mentioned setting...Hello,
there is configuration option ALLOWED_EXTERNAL_OPENID_REDIRECT_DOMAINS. Is it good for something? OPENID login is working on libravatar-stg even though the domain name is currently not being present in the above-mentioned setting.
Thank you!
climeOliver Falkoliver@linux-kernel.atOliver Falkoliver@linux-kernel.athttps://git.linux-kernel.at/oliver/ivatar/-/issues/32Make it possible to use SMTP email backend for sending email2021-09-06T11:50:17ZGhost UserMake it possible to use SMTP email backend for sending emailHello,
currently, only mailgun email backend is available. Can we make email backend configurable so that postfix can be employed for sending emails?
Thank you!Hello,
currently, only mailgun email backend is available. Can we make email backend configurable so that postfix can be employed for sending emails?
Thank you!Oliver Falkoliver@linux-kernel.atOliver Falkoliver@linux-kernel.athttps://git.linux-kernel.at/oliver/ivatar/-/issues/31home page should show topbar when user is logged in2021-09-06T11:50:09ZGhost Userhome page should show topbar when user is logged inWhen I click at home in my profile. I am redirected to home page, from which I can't easily (without a back button) get into my profile again. It would be nice if the top bar for logged in users was shown on homepage as well.When I click at home in my profile. I am redirected to home page, from which I can't easily (without a back button) get into my profile again. It would be nice if the top bar for logged in users was shown on homepage as well.Oliver Falkoliver@linux-kernel.atOliver Falkoliver@linux-kernel.athttps://git.linux-kernel.at/oliver/ivatar/-/issues/30ivatar uses gravatar way too often?2021-09-06T11:49:56ZGhost Userivatar uses gravatar way too often?If I make up some random hash and use it, I get:
http://libravatar-stg.fedorainfracloud.org/avatar/40f8d096a3777232204cb3f796c577b7?s=500
vs.
http://cdn.libravatar.org/avatar/40f8d096a3777232204cb3f796c577b7?s=500
In the first case, ...If I make up some random hash and use it, I get:
http://libravatar-stg.fedorainfracloud.org/avatar/40f8d096a3777232204cb3f796c577b7?s=500
vs.
http://cdn.libravatar.org/avatar/40f8d096a3777232204cb3f796c577b7?s=500
In the first case, gravatar is used as a source to get avatar. In the second case, libravatar's default avatar is used. I wonder what are the rules when gravatar should be used and when not.
This is more a question than a bug report.https://git.linux-kernel.at/oliver/ivatar/-/issues/28TODO TODO TODO on Contact page under Bug Tracker2021-09-06T11:49:46ZGhost UserTODO TODO TODO on Contact page under Bug TrackerHello,
there is unfinished text under "Bug Tracker" title on Contacts page. I think it is just missing link to this Gitlab's bugtracker.Hello,
there is unfinished text under "Bug Tracker" title on Contacts page. I think it is just missing link to this Gitlab's bugtracker.Oliver Falkoliver@linux-kernel.atOliver Falkoliver@linux-kernel.athttps://git.linux-kernel.at/oliver/ivatar/-/issues/27Cannot log into my account under my openID, instead new account is created2021-09-06T11:49:38ZGhost UserCannot log into my account under my openID, instead new account is createdHello,
I have imported data into libravatar-stg.fedorainfracloud.org and tried to log under my openID http://clime.id.fedoraproject.org. Instead of logging into my account for username browserid376, I got logged into a new account, whic...Hello,
I have imported data into libravatar-stg.fedorainfracloud.org and tried to log under my openID http://clime.id.fedoraproject.org. Instead of logging into my account for username browserid376, I got logged into a new account, which was automatically created at that point.
For original libravatar, users are able to log into their accounts under their confirmed openIDs. I think we want that behavior too.Oliver Falkoliver@linux-kernel.atOliver Falkoliver@linux-kernel.athttps://git.linux-kernel.at/oliver/ivatar/-/issues/26libravatar's import/export data do not store relation between confirmed email...2021-09-06T11:49:30ZGhost Userlibravatar's import/export data do not store relation between confirmed email/openid and photosPhotos, confirmed emails, and confirmed openIDs are all imported independently. If I have have some photo assigned to a certain email on current libravatar instance, this relation is not transferred through export/import operation.Photos, confirmed emails, and confirmed openIDs are all imported independently. If I have have some photo assigned to a certain email on current libravatar instance, this relation is not transferred through export/import operation.https://git.linux-kernel.at/oliver/ivatar/-/issues/25libravatar's export/import scripts don't account for password2021-09-06T11:49:13ZGhost Userlibravatar's export/import scripts don't account for passwordHello,
https://git.linux-kernel.at/oliver/ivatar/blob/libravatar_export/exportaccounts.py
nor
https://git.linux-kernel.at/oliver/ivatar/blob/master/import_libravatar.py
account for user password. I think we might want to transfer those...Hello,
https://git.linux-kernel.at/oliver/ivatar/blob/libravatar_export/exportaccounts.py
nor
https://git.linux-kernel.at/oliver/ivatar/blob/master/import_libravatar.py
account for user password. I think we might want to transfer those as well.Oliver Falkoliver@linux-kernel.atOliver Falkoliver@linux-kernel.athttps://git.linux-kernel.at/oliver/ivatar/-/issues/24content for security link is missing2021-09-06T11:49:06ZGhost Usercontent for security link is missingHello,
when I click on "Security" item in top bar when logged in*, I get an error about non-existing template. Do we have any intended content for that tab or could we simply drop it?
*[Screenshot_from_2018-12-27_22-20-07](/uploads/a5...Hello,
when I click on "Security" item in top bar when logged in*, I get an error about non-existing template. Do we have any intended content for that tab or could we simply drop it?
*[Screenshot_from_2018-12-27_22-20-07](/uploads/a5b7cbc1efce7c05eed5829c4b1127ab/Screenshot_from_2018-12-27_22-20-07.png)Oliver Falkoliver@linux-kernel.atOliver Falkoliver@linux-kernel.athttps://git.linux-kernel.at/oliver/ivatar/-/issues/23PasswordReset form doesn't send any emails2021-09-06T11:48:58ZGhost UserPasswordReset form doesn't send any emailsHello!
there is a problem with password reset form. Namely, ivatar doesn't set user.email attribute and django checks on that attribute when sending a password-reset email:
https://github.com/django/django/blob/master/django/contrib/au...Hello!
there is a problem with password reset form. Namely, ivatar doesn't set user.email attribute and django checks on that attribute when sending a password-reset email:
https://github.com/django/django/blob/master/django/contrib/auth/forms.py#L260
A solution here could be to override: PasswordResetForm:get_users method.https://git.linux-kernel.at/oliver/ivatar/-/issues/21Requests with a negative size option crash ivatar2021-09-06T11:48:47ZGhost UserRequests with a negative size option crash ivatarExample:
```
curl -i "https://avatars.linux-kernel.at/avatar/4751ed9aae86881d2b45dd0512c3e14a?s=-19"
```
This produce an uncatched ValueError exception with the following message: “height and width must be > 0”.
My implementation retu...Example:
```
curl -i "https://avatars.linux-kernel.at/avatar/4751ed9aae86881d2b45dd0512c3e14a?s=-19"
```
This produce an uncatched ValueError exception with the following message: “height and width must be > 0”.
My implementation returns an HTTP status code 400 while libravatar returns an image with the default size.https://git.linux-kernel.at/oliver/ivatar/-/issues/20nobody.png is returned instead of MysteryMan2021-09-06T11:48:41ZGhost Usernobody.png is returned instead of MysteryManNow it is the other way around ! :laughing:
When requesting a non existing user's avatar with a `default` option of 'mm' or 'mp' the nobody.png picture is returned instead of 'mm.png'.
Example:
```
curl -L https://avatars.linux-kerne...Now it is the other way around ! :laughing:
When requesting a non existing user's avatar with a `default` option of 'mm' or 'mp' the nobody.png picture is returned instead of 'mm.png'.
Example:
```
curl -L https://avatars.linux-kernel.at/avatar/4751ed9aae86881d2b45dd0512c3e14a?d=mm&f=y
```
This regression doesn't affect values of 'identicon' or 'retro'.Oliver Falkoliver@linux-kernel.atOliver Falkoliver@linux-kernel.athttps://git.linux-kernel.at/oliver/ivatar/-/issues/17Error 500 on invalid size option2021-09-06T11:48:25ZGhost UserError 500 on invalid size optionWhen requesting an avatar with a non-integer size such as the word “mille” (or anything else) ivatar seems to crash and returns a HTTP 500 error code.
Example:
```curl -i https://avatars.linux-kernel.at/avatar/4751ed9aae86881d2b45dd051...When requesting an avatar with a non-integer size such as the word “mille” (or anything else) ivatar seems to crash and returns a HTTP 500 error code.
Example:
```curl -i https://avatars.linux-kernel.at/avatar/4751ed9aae86881d2b45dd0512c3e14a?s=mille```
Issue found with my tests script `ivatar.t`.Feature complete - one month before go liveOliver Falkoliver@linux-kernel.atOliver Falkoliver@linux-kernel.athttps://git.linux-kernel.at/oliver/ivatar/-/issues/16Importing pictures from another libravatar instance is broken2021-09-06T11:48:18ZGhost UserImporting pictures from another libravatar instance is brokenThe function `get_context_data` in the class `ImportPhotoView` from the `ivatar/ivataraccount/views.py` file generates a broken URL.
In this snippet the variable `libravatar_service_url` already contains an option at the end, namely '?d...The function `get_context_data` in the class `ImportPhotoView` from the `ivatar/ivataraccount/views.py` file generates a broken URL.
In this snippet the variable `libravatar_service_url` already contains an option at the end, namely '?d=404' :
```
libravatar_service_url = libravatar_url(
email=addr,
default=404,
)
```
A few lines later '?s=512' or '?s=80' is concatenated.Oliver Falkoliver@linux-kernel.atOliver Falkoliver@linux-kernel.at