ivatar issueshttps://git.linux-kernel.at/oliver/ivatar/-/issues2021-09-06T11:47:05Zhttps://git.linux-kernel.at/oliver/ivatar/-/issues/5s option: size 02021-09-06T11:47:05ZGhost Users option: size 0According to Libravatar specification the correct image size a user can request should be between 1 and 512 inclusive. Here 0 (zero) is accepted but trigger a division by zero.
In this case Gravatar ignores the option[1] while my implem...According to Libravatar specification the correct image size a user can request should be between 1 and 512 inclusive. Here 0 (zero) is accepted but trigger a division by zero.
In this case Gravatar ignores the option[1] while my implementation returns a HTTP 400 error[2].
[1]: https://www.gravatar.com/avatar/4751ed9aae86881d2b45dd0512c3e14a?s=0
[2]: https://avatars.bouledef.eu/avatar/4751ed9aae86881d2b45dd0512c3e14a?s=0Oliver Falkoliver@linux-kernel.atOliver Falkoliver@linux-kernel.athttps://git.linux-kernel.at/oliver/ivatar/-/issues/4s option: invalid value handling2021-09-06T11:46:53ZGhost Users option: invalid value handlingAssigning the empty string and just any non-integer value to the option `s` will cause a `ValueError` exception to be thrawn.
In this case Gravatar ignores the option[1] while my implementation returns a HTTP 400 error[2].
[1]: https:/...Assigning the empty string and just any non-integer value to the option `s` will cause a `ValueError` exception to be thrawn.
In this case Gravatar ignores the option[1] while my implementation returns a HTTP 400 error[2].
[1]: https://www.gravatar.com/avatar/4751ed9aae86881d2b45dd0512c3e14a?s=
[2]: https://avatars.bouledef.eu/avatar/4751ed9aae86881d2b45dd0512c3e14a?s=Oliver Falkoliver@linux-kernel.atOliver Falkoliver@linux-kernel.athttps://git.linux-kernel.at/oliver/ivatar/-/issues/45The default option is not respected anymore2021-09-06T11:46:50ZGhost UserThe default option is not respected anymoreA request for a random, non-existing hash such as one generated with `sha256 -qs invalid$RANDOM` with a default of `404` or `retro` or any other valid value for this option is now ignored. Instead ivatar redirects to `/gravatarproxy/...?...A request for a random, non-existing hash such as one generated with `sha256 -qs invalid$RANDOM` with a default of `404` or `retro` or any other valid value for this option is now ignored. Instead ivatar redirects to `/gravatarproxy/...?s=80`, then on `/avatar/...?s=80&forcedefault=y` and finally redirects to nobody.png.
Perhaps all options should be passed instead of just the size ? I tested the same request with a non-default size and it was passed on as expected.
Example:
```
$ curl -iL "https://libravatar-stg.fedorainfracloud.org/avatar/$(sha256 -qs invalid$RANDOM)?d=404"
HTTP/1.1 302 Found
Date: Tue, 19 Feb 2019 16:00:56 GMT
Server: Apache/2.4.34 (Fedora) OpenSSL/1.1.0i-fips mod_wsgi/4.5.20 Python/3.6
Strict-Transport-Security: max-age=31536000; preload
Location: /gravatarproxy/985993fa4f05b8195da128cbf86c6fb1d6c2fbcbf3861865d93fd214aacce2f0?s=80
Content-Length: 0
Vary: Accept-Language,Cookie
Content-Language: en
X-Frame-Options: SAMEORIGIN
Content-Type: text/html; charset=utf-8
HTTP/1.1 302 Found
Date: Tue, 19 Feb 2019 16:00:56 GMT
Server: Apache/2.4.34 (Fedora) OpenSSL/1.1.0i-fips mod_wsgi/4.5.20 Python/3.6
Strict-Transport-Security: max-age=31536000; preload
Location: /avatar/985993fa4f05b8195da128cbf86c6fb1d6c2fbcbf3861865d93fd214aacce2f0?s=80&forcedefault=y
Content-Length: 0
Vary: Accept-Language,Cookie
Content-Language: en
X-Frame-Options: SAMEORIGIN
Content-Type: text/html; charset=utf-8
HTTP/1.1 302 Found
Date: Tue, 19 Feb 2019 16:00:57 GMT
Server: Apache/2.4.34 (Fedora) OpenSSL/1.1.0i-fips mod_wsgi/4.5.20 Python/3.6
Strict-Transport-Security: max-age=31536000; preload
Location: /static/img/nobody/80.png
Content-Length: 0
Vary: Accept-Language,Cookie
Content-Language: en
X-Frame-Options: SAMEORIGIN
Content-Type: text/html; charset=utf-8
HTTP/1.1 200 OK
Date: Tue, 19 Feb 2019 16:00:57 GMT
Server: Apache/2.4.34 (Fedora) OpenSSL/1.1.0i-fips mod_wsgi/4.5.20 Python/3.6
Strict-Transport-Security: max-age=31536000; preload
Last-Modified: Wed, 14 Nov 2018 14:53:30 GMT
ETag: "9f4-57aa118f1484d"
Accept-Ranges: bytes
Content-Length: 2548
Content-Type: image/png
```Oliver Falkoliver@linux-kernel.atOliver Falkoliver@linux-kernel.athttps://git.linux-kernel.at/oliver/ivatar/-/issues/3gitlab: no ssh-based access to git repository2021-09-06T11:46:41ZGhost Usergitlab: no ssh-based access to git repositoryAn infrastructure wish: please enable the ssh transport for git. Thank you!An infrastructure wish: please enable the ssh transport for git. Thank you!https://git.linux-kernel.at/oliver/ivatar/-/issues/42Mail/Photo association on import doesn't work2021-09-06T11:46:04ZGhost UserMail/Photo association on import doesn't workEither export broken or importEither export broken or importOliver Falkoliver@linux-kernel.atOliver Falkoliver@linux-kernel.athttps://git.linux-kernel.at/oliver/ivatar/-/issues/22Implement gravatar fallback2021-09-06T11:43:05ZGhost UserImplement gravatar fallbackDefault: Fallback to gravatar to local gravatar proxying under /gravatar/
Alternative: Directly redirect to gravatar.com
Alternative2: Disable redirect/fallback at all.Default: Fallback to gravatar to local gravatar proxying under /gravatar/
Alternative: Directly redirect to gravatar.com
Alternative2: Disable redirect/fallback at all.Oliver Falkoliver@linux-kernel.atOliver Falkoliver@linux-kernel.athttps://git.linux-kernel.at/oliver/ivatar/-/issues/18The MysteryMan avatar is returned when a non-existing user is requested with ...2021-09-06T11:43:00ZGhost UserThe MysteryMan avatar is returned when a non-existing user is requested with an empty default optionWhen an avatar is requested with a malformed `default` option with no value on a non-existing user the 'mm.png' file is returned.
Example:
```
curl -i https://avatars.linux-kernel.at/avatar/nobodyasdasdasdasdashdakhdkjhkaa?d=
```
Whil...When an avatar is requested with a malformed `default` option with no value on a non-existing user the 'mm.png' file is returned.
Example:
```
curl -i https://avatars.linux-kernel.at/avatar/nobodyasdasdasdasdashdakhdkjhkaa?d=
```
While not technically against the API this is not the behaviour of both Libravatar 0.1 and Gravatar, where the default 'nobody.png' file is used instead. This is mentioned briefly, although I think not very clearly, in the documentation:
> d or default parameter defaults to the Libravatar logo
Issue found with my tests script `ivatar.t`.Feature complete - one month before go liveOliver Falkoliver@linux-kernel.atOliver Falkoliver@linux-kernel.athttps://git.linux-kernel.at/oliver/ivatar/-/issues/19Wrong size is returned for default=retro and default=identicon2021-09-06T11:42:47ZGhost UserWrong size is returned for default=retro and default=identiconWhen an avatar is requested with a default option of 'retro' or 'identicon' on a non-existing user a wrongly sized image is returned. This image will always be 20px large.
Example:
```
https://avatars.linux-kernel.at/avatar/nobodyasdas...When an avatar is requested with a default option of 'retro' or 'identicon' on a non-existing user a wrongly sized image is returned. This image will always be 20px large.
Example:
```
https://avatars.linux-kernel.at/avatar/nobodyasdasdasdasdashdakhdkjhkaa?s=80&d=retro
```
This image will be 100 pixels wide.
Issue found with my tests script `ivatar.t`.Feature complete - one month before go liveOliver Falkoliver@linux-kernel.atOliver Falkoliver@linux-kernel.athttps://git.linux-kernel.at/oliver/ivatar/-/issues/53500 error on trying to upload export in invalid format2021-09-06T11:42:43ZGhost User500 error on trying to upload export in invalid formatHello,
on https://www.libravatar.org/accounts/upload_export/, if i try to upload e.g. a txt file i get 500 error. Instead, the file should be checked for a valid format and only then processed.Hello,
on https://www.libravatar.org/accounts/upload_export/, if i try to upload e.g. a txt file i get 500 error. Instead, the file should be checked for a valid format and only then processed.Oliver Falkoliver@linux-kernel.atOliver Falkoliver@linux-kernel.athttps://git.linux-kernel.at/oliver/ivatar/-/issues/62libravatar.org footer covers content in firefox2021-09-06T11:41:31ZGhost Userlibravatar.org footer covers content in firefoxIn Firefox, the page footer covers whatever part of the page it is over when the page loads. Scrolling on the page moves the footer as well as the page content.
The page footer has css of "position: absolute;" in FF, but has "position:...In Firefox, the page footer covers whatever part of the page it is over when the page loads. Scrolling on the page moves the footer as well as the page content.
The page footer has css of "position: absolute;" in FF, but has "position: relative;" in Chrome where it behaves as expected.
Of no real consequence: in FF the footer is just a box but in Chrome it is a fancy curve topped element.![libravatar_home_page_in_FF](/uploads/1f101ffaabe2e72c822e18b2d013374a/libravatar_home_page_in_FF.png)https://git.linux-kernel.at/oliver/ivatar/-/issues/29Outdated links on front page2021-09-06T11:35:53ZGhost UserOutdated links on front pageHello!
The source code link on frontpage should likely link to this repo, not to https://code.launchpad.net/libravatar.
The same for "Report bugs"/"Questions". "Security" link doesn't work.Hello!
The source code link on frontpage should likely link to this repo, not to https://code.launchpad.net/libravatar.
The same for "Report bugs"/"Questions". "Security" link doesn't work.https://git.linux-kernel.at/oliver/ivatar/-/issues/65„+“ in mail address doesn‘t work for photo import2020-04-23T09:17:26ZOliver Falkoliver@linux-kernel.at„+“ in mail address doesn‘t work for photo importAccording to
https://twitter.com/webknjaz/status/1252558228518559746?s=21
„+“ in mail address doesn‘t work.According to
https://twitter.com/webknjaz/status/1252558228518559746?s=21
„+“ in mail address doesn‘t work.Oliver Falkoliver@linux-kernel.atOliver Falkoliver@linux-kernel.athttps://git.linux-kernel.at/oliver/ivatar/-/issues/61Maintenance page2020-02-25T11:29:27ZOliver Falkoliver@linux-kernel.atMaintenance pageAdd config option to allow a maintenance page to show up instead of the normal user interface, but still allow avatars to be served.
So => No write, just read.Add config option to allow a maintenance page to show up instead of the normal user interface, but still allow avatars to be served.
So => No write, just read.Migration 02/2020Oliver Falkoliver@linux-kernel.atOliver Falkoliver@linux-kernel.athttps://git.linux-kernel.at/oliver/ivatar/-/issues/56W3 validator throws issues2019-05-28T08:24:29ZOliver Falkoliver@linux-kernel.atW3 validator throws issueshttps://validator.w3.org/nu/?doc=https%3A%2F%2Fwww.libravatar.org%2Fhttps://validator.w3.org/nu/?doc=https%3A%2F%2Fwww.libravatar.org%2Fhttps://git.linux-kernel.at/oliver/ivatar/-/issues/40Style for check_domain2019-02-23T21:44:48ZOliver Falkoliver@linux-kernel.atStyle for check_domainThe current style of check_domain has been taken over (mostly) from the old site and is using tables to style the result.
Would be cool, if we can restyle this.
Example:
https://libravatar-stg.fedorainfracloud.org/tools/check_domain/
Can...The current style of check_domain has been taken over (mostly) from the old site and is using tables to style the result.
Would be cool, if we can restyle this.
Example:
https://libravatar-stg.fedorainfracloud.org/tools/check_domain/
Can I assign this to you @nipos ?https://git.linux-kernel.at/oliver/ivatar/-/issues/1Write INSTALL.md2019-02-21T08:53:19ZOliver Falkoliver@linux-kernel.atWrite INSTALL.mdThere's only 'TODO' in INSTALL.md at the moment. Write some real documentatino.There's only 'TODO' in INSTALL.md at the moment. Write some real documentatino.Feature complete - one month before go livehttps://git.linux-kernel.at/oliver/ivatar/-/issues/2Security check2019-02-21T08:52:03ZOliver Falkoliver@linux-kernel.atSecurity checkI believe there should be no real big security issue, but if someone could check, I'd appreciate!I believe there should be no real big security issue, but if someone could check, I'd appreciate!Feature complete - one month before go liveOliver Falkoliver@linux-kernel.atOliver Falkoliver@linux-kernel.athttps://git.linux-kernel.at/oliver/ivatar/-/issues/13Add RoboHash?2019-02-21T08:51:43ZOliver Falkoliver@linux-kernel.atAdd RoboHash?If we want RoboHash, this should receive some votes, else, I'll not care too much:
https://github.com/e1ven/RobohashIf we want RoboHash, this should receive some votes, else, I'll not care too much:
https://github.com/e1ven/RobohashAdditional features (not required for go-live)Oliver Falkoliver@linux-kernel.atOliver Falkoliver@linux-kernel.athttps://git.linux-kernel.at/oliver/ivatar/-/issues/41Account deletion doesn't work2019-02-19T10:36:02ZOliver Falkoliver@linux-kernel.atAccount deletion doesn't workGives error 500Gives error 500Oliver Falkoliver@linux-kernel.atOliver Falkoliver@linux-kernel.athttps://git.linux-kernel.at/oliver/ivatar/-/issues/9Login with OpenID should automatically add OpenID identity2018-12-05T15:48:21ZOliver Falkoliver@linux-kernel.atLogin with OpenID should automatically add OpenID identityIf you login with https://avatars.linux-kernel.at/openid/login/, it will not automatically create your OpenID identity, but it should, since it's kinda confirmed at that point already.If you login with https://avatars.linux-kernel.at/openid/login/, it will not automatically create your OpenID identity, but it should, since it's kinda confirmed at that point already.Additional features (not required for go-live)Oliver Falkoliver@linux-kernel.atOliver Falkoliver@linux-kernel.at